Skip to content

Commit

Permalink
http2: fix [kInspect]() output for Http2Stream
Browse files Browse the repository at this point in the history
This fixes a typo in the util.inspect output of Http2Stream. It
previously had writeableSate instead of writableState.

PR-URL: #14753
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
evanlucas authored and addaleax committed Aug 14, 2017
1 parent 621c03a commit 1d40850
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,7 @@ class Http2Stream extends Duplex {
id: this[kID],
state: this.state,
readableState: this._readableState,
writeableSate: this._writableState
writableState: this._writableState
};
return `Http2Stream ${util.format(obj)}`;
}
Expand Down
29 changes: 29 additions & 0 deletions test/parallel/test-http2-stream-client.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const util = require('util');

const server = http2.createServer();
server.on('stream', common.mustCall((stream) => {
assert.strictEqual(stream.aborted, false);
const insp = util.inspect(stream);
assert.ok(/Http2Stream { id/.test(insp));
assert.ok(/ state:/.test(insp));
assert.ok(/ readableState:/.test(insp));
assert.ok(/ writableState:/.test(insp));
stream.end('ok');
}));
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.resume();
req.on('streamClosed', common.mustCall(() => {
client.destroy();
server.close();
}));
}));

0 comments on commit 1d40850

Please sign in to comment.