Skip to content

Commit 1cfe058

Browse files
authored
test: fix test-permission-deny-fs-wildcard (win32)
The test fails on Windows when the working directory is not on a 'C:' drive. For example, it always fails during the coverage-windows GitHub action, which runs tests on drive 'D:'. Fixes: #47093 PR-URL: #47095 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
1 parent f543c05 commit 1cfe058

File tree

1 file changed

+18
-15
lines changed

1 file changed

+18
-15
lines changed

test/parallel/test-permission-deny-fs-wildcard.js

+18-15
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,28 @@ common.skipIfWorker();
66

77
const assert = require('assert');
88
const fs = require('fs');
9+
const path = require('path');
910

1011
if (common.isWindows) {
12+
const { root } = path.parse(process.cwd());
13+
const abs = (p) => path.join(root, p);
1114
const denyList = [
12-
'C:\\tmp\\*',
13-
'C:\\example\\foo*',
14-
'C:\\example\\bar*',
15-
'C:\\folder\\*',
16-
'C:\\show',
17-
'C:\\slower',
18-
'C:\\slown',
19-
'C:\\home\\foo\\*',
20-
];
15+
'tmp\\*',
16+
'example\\foo*',
17+
'example\\bar*',
18+
'folder\\*',
19+
'show',
20+
'slower',
21+
'slown',
22+
'home\\foo\\*',
23+
].map(abs);
2124
assert.ok(process.permission.deny('fs.read', denyList));
22-
assert.ok(process.permission.has('fs.read', 'C:\\slow'));
23-
assert.ok(process.permission.has('fs.read', 'C:\\slows'));
24-
assert.ok(!process.permission.has('fs.read', 'C:\\slown'));
25-
assert.ok(!process.permission.has('fs.read', 'C:\\home\\foo'));
26-
assert.ok(!process.permission.has('fs.read', 'C:\\home\\foo\\'));
27-
assert.ok(process.permission.has('fs.read', 'C:\\home\\fo'));
25+
assert.ok(process.permission.has('fs.read', abs('slow')));
26+
assert.ok(process.permission.has('fs.read', abs('slows')));
27+
assert.ok(!process.permission.has('fs.read', abs('slown')));
28+
assert.ok(!process.permission.has('fs.read', abs('home\\foo')));
29+
assert.ok(!process.permission.has('fs.read', abs('home\\foo\\')));
30+
assert.ok(process.permission.has('fs.read', abs('home\\fo')));
2831
} else {
2932
const denyList = [
3033
'/tmp/*',

0 commit comments

Comments
 (0)