domain: show falsy names as anonymous for DEP0097

Many anonymous functions use the empty string as their name.
Since the DEP0097 logic was using nullish coalescing, these
functions were not being displayed as anonymous. This commit
updates the logic to use || instead of ??.

PR-URL: #37550
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

lib/domain.js

@@ -130,7 +130,7 @@ function emitMakeCallbackDeprecation({ target, method }) {
       'Using a domain property in MakeCallback is deprecated. Use the ' +
       'async_context variant of MakeCallback or the AsyncResource class ' +
       'instead. ' +
-      `(Triggered by calling ${method?.name ?? '<anonymous>'} ` +
+      `(Triggered by calling ${method?.name || '<anonymous>'} ` +
       `on ${target?.constructor?.name}.)`,
       'DeprecationWarning', 'DEP0097');
     sendMakeCallbackDeprecation = true;

test/parallel/test-domain-dep0097.js

@@ -0,0 +1,17 @@
+'use strict';
+const common = require('../common');
+
+common.skipIfInspectorDisabled();
+
+const assert = require('assert');
+const domain = require('domain');
+const inspector = require('inspector');
+
+process.on('warning', common.mustCall((warning) => {
+  assert.strictEqual(warning.code, 'DEP0097');
+  assert.match(warning.message, /Triggered by calling <anonymous> on process/);
+}));
+
+domain.create().run(() => {
+  inspector.open();
+});