Skip to content

Commit 19867ce

Browse files
mhdawsonjasnell
authored andcommitted
deps: exclude tests on ppc for v8 5.0
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: #6267 Fixes: #6236 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent ce14468 commit 19867ce

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

deps/v8/test/cctest/cctest.status

+7
Original file line numberDiff line numberDiff line change
@@ -615,4 +615,11 @@
615615
'test-api/InitializeDefaultIsolateOnSecondaryThread1': [PASS, ['mode == debug', FAIL]],
616616
}],
617617

618+
##############################################################################
619+
# exclude test issues for which fixes for PPC did not make it into 5.0
620+
# These should be removed when we upgrade Node.js to use v8 5.1
621+
['arch == ppc64', {
622+
'test-heap/ReleaseOverReservedPages' : [SKIP],
623+
}], # 'arch == ppc64''
624+
618625
]

deps/v8/test/mjsunit/mjsunit.status

+7
Original file line numberDiff line numberDiff line change
@@ -923,4 +923,11 @@
923923
'big-array-literal': [SKIP],
924924
}], # 'gcov_coverage'
925925

926+
##############################################################################
927+
# exclude test issues for which fixes for PPC did not make it into 5.0
928+
# These should be removed when we upgrade Node.js to use v8 5.1
929+
['arch == ppc64', {
930+
'wasm/asm-wasm' : [SKIP],
931+
}], # 'arch == ppc64''
932+
926933
]

0 commit comments

Comments
 (0)