-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add a test to ensure the correctness of timezone upgrades
Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in RaisinTen#4. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #45299 Reviewed-By: Antoine du Hamel <[email protected]>
- Loading branch information
1 parent
c77f660
commit 197df63
Showing
3 changed files
with
32 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
2022e |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
|
||
if (!common.hasIntl) { | ||
common.skip('missing Intl'); | ||
} | ||
|
||
// Refs: https://github.com/nodejs/node/blob/1af63a90ca3a59ca05b3a12ad7dbea04008db7d9/configure.py#L1694-L1711 | ||
if (process.config.variables.icu_path !== 'deps/icu-small') { | ||
// If Node.js is configured to use its built-in ICU, it uses a strict subset | ||
// of ICU formed using `tools/icu/shrink-icu-src.py`, which is present in | ||
// `deps/icu-small`. It is not the same as configuring the build with | ||
// `./configure --with-intl=small-icu`. The latter only uses a subset of the | ||
// locales, i.e., it uses the English locale, `root,en`, by default and other | ||
// locales can also be specified using the `--with-icu-locales` option. | ||
common.skip('not using the icu data file present in deps/icu-small/source/data/in/icudt##l.dat.bz2'); | ||
} | ||
|
||
const fixtures = require('../common/fixtures'); | ||
|
||
// This test ensures the correctness of the automated timezone upgrade PRs. | ||
|
||
const { strictEqual } = require('assert'); | ||
const { readFileSync } = require('fs'); | ||
|
||
const expectedVersion = readFileSync(fixtures.path('tz-version.txt'), 'utf8').trim(); | ||
strictEqual(process.versions.tz, expectedVersion); |