report: fix recent coverity warning

Fix warning about dereferencing null env Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48954 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Sep 10, 2023 · 173aed4 · 173aed4
1 parent f637fd4
commit 173aed4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/node_report.cc b/src/node_report.cc
@@ -857,9 +857,13 @@ std::string TriggerNodeReport(Isolate* isolate,
   // Determine the required report filename. In order of priority:
   //   1) supplied on API 2) configured on startup 3) default generated
   if (!name.empty()) {
-    THROW_IF_INSUFFICIENT_PERMISSIONS(
-        env, permission::PermissionScope::kFileSystemWrite, name, name);
-    // Filename was specified as API parameter.
+    // we may not always be in a great state when generating a node report
+    // allow for the case where we don't have an env
+    if (env != nullptr) {
+      THROW_IF_INSUFFICIENT_PERMISSIONS(
+          env, permission::PermissionScope::kFileSystemWrite, name, name);
+      // Filename was specified as API parameter.
+    }
     filename = name;
   } else {
     std::string report_filename;