From 16624b404c39842baf4bc69674f266d23dbd1419 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 28 Oct 2021 21:25:53 -0700 Subject: [PATCH] tools,meta: remove exclusions from AUTHORS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The update-authors tool omits Chromium team members. This was a decision made years ago. The idea was that these folks contributed to V8 not to Node.js, as they typically ended up in our code-base via cherry-picked commits from V8. Ref: https://github.com/nodejs/node/pull/232#discussion-diff-22412788 Now that there are over 3000 contributors identified in AUTHORS, some of whom are bots that we run, I think it's time to undo this exception. If we used someone else's code in a cherry-pick, congratulations to them, they're authors. In particular, this will fix the omission of Yang Guo who contributed extensively to Node.js outside of V8 contributions. PR-URL: https://github.com/nodejs/node/pull/40648 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso --- .mailmap | 38 +++++++++++++++++++++++--------------- AUTHORS | 37 ++++++++++++++++++++++++++++++++++++- tools/update-authors.js | 4 +--- 3 files changed, 60 insertions(+), 19 deletions(-) diff --git a/.mailmap b/.mailmap index d78783b34f7465..9d3e0cf225bdb5 100644 --- a/.mailmap +++ b/.mailmap @@ -51,6 +51,7 @@ Ben Lugavere Ben Noordhuis Ben Noordhuis Ben Taber +Benedikt Meurer Benjamin Coe Benjamin Coe Benjamin Fleischer @@ -94,6 +95,7 @@ Corey Martin Cyril Lakech <1169286+clakech@users.noreply.github.com> Daiki Arai Damien Simonin Feugas +Dan Carney Dan Fabulich Dan Kaplun Dan Williams @@ -101,6 +103,7 @@ Daniel Abrão Daniel Berger Daniel Bevenius Daniel Chcouri <333222@gmail.com> +Daniel Clifford Daniel Gröber Daniel Gröber Daniel Paulino @@ -111,9 +114,9 @@ Danielle Adams Danny Guo Danny Nemer Danny Nemer -Dave Olszewski Darshan Sen Darshan Sen +Dave Olszewski Dave Pacheco David Cai David Mark Clements @@ -129,8 +132,10 @@ Eduard Burtescu Einar Otto Stangvik Elliott Cable Emanuel Buholzer +Enrico Pertoso Eric Bickle Eric Phetteplace +Erik Corry Ernesto Salazar Erwin W. Ramadhan Ethan Arrowood @@ -156,6 +161,7 @@ Florian Margaine Forrest L Norvell Forrest L Norvell Franziska Hinkelmann +Franziska Hinkelmann Friedemann Altrock Fuji Goro Gabriel de Perthuis @@ -198,6 +204,7 @@ Isuru Siriwardana Italo A. Casas Jackson Tian Jake Verbaten +Jakob Kummerow Jamen Marzonie James Beavers James Bromwell <943160+thw0rted@users.noreply.github.com> @@ -213,12 +220,14 @@ Jennifer Bland JeongHoon Byun Jered Schmidt Jeremiah Senkpiel +Jeremy Apthorp Jérémy Lal Jérémy Lal Jerry Chin Jessica Quynh Tran Jesús Leganés-Combarro 'piranna Jimb Esser +Jochen Eisinger Joe Shaw Johan Bergström Johan Dahlberg @@ -261,6 +270,7 @@ Kazuyuki Yamada Ke Ding Keith M Wesolowski Kelsey Breseman +Kevin Millikin Khaidi Chu Khaidi Chu Kimberly Wilber @@ -274,6 +284,7 @@ Kyle Robinson Young Lakshmi Swetha Gopireddy Lakshmi Swetha Gopireddy Lars-Magnus Skog +Lasse R.H. Nielsen Leeseean Chiu Lucas Pardue Luke Bayes @@ -307,8 +318,10 @@ Matthew Lye Matthew Turner Matthias Bastian Maurice Hayward +Maya Lekova Michael Bernstein Michael Dawson +Michael Starzinger Michaël Zasso Michael-Rainabba Richardson Michał Gołębiowski-Owczarek @@ -341,6 +354,7 @@ Nikolai Vavilov Nils Kuhnhenn Nitzan Uziely Noah Rose Ledesma +Oliver Chang Oluwaseun Omoyajowo Onne Gorter Oscar Martinez @@ -349,6 +363,7 @@ Paul Querna Pedro Lima Peng Lyu Peter Flannery +Peter Marshall Peter Marton Peter Paugh Phillip Johnsen @@ -393,9 +408,9 @@ Sam Roberts Sam Shull Sam Shull Sam Shull -Samuel Attard Samantha Sample <=> Sambasiva Suda +Samuel Attard San-Tai Hsu Santiago Gimeno Sarah Meyer @@ -431,6 +446,7 @@ Stewart X Addison Suraiya Hameed Suramya shah Surya Panikkal +Sven Panne Szymon Marczak <36894700+szmarczak@users.noreply.github.com> Tadashi SAWADA Tadhg Creedon @@ -454,6 +470,7 @@ Tim Price Tim Ruffles Tim Smart Tim Smart +Timothy Gu Timothy Leverett Timothy O. Peters Timur Shemsedinov @@ -471,20 +488,22 @@ Tom Hughes-Croucher Tom Purcell Tom White Tomoki Okahana +Toon Verwaest Tracy Hinds Travis Meisenheimer Trevor Burnham Trivikram Kamat <16024985+trivikr@users.noreply.github.com> ttzztztz Tyler Larson -Ujjwal Sharma Ujjwal Sharma +Ujjwal Sharma Uttam Pawar Viktor Karpov Vincent Voyer Vladimir de Turckheim Voltrex <62040526+VoltrexMaster@users.noreply.github.com> vsemozhetbyt +Vyacheslav Egorov Wang Xinyong Wei-Wei Wu Weijia Wang @@ -498,6 +517,7 @@ Xavier J Ortiz xiaoyu <306766053@qq.com> Xu Meng Yael Hermon +Yang Guo ycjcl868 <45808948@qq.com> Yingchen Xue Yongsheng Zhang @@ -515,15 +535,3 @@ Zachary Vacura Zoran Tomicic Сковорода Никита Андреевич 隋鑫磊 - -# These people didn't contribute patches to node directly, -# but we've landed their v8 patches in the node repository: -Daniel Clifford -Erik Corry -Jakob Kummerow -Kevin Millikin -Lasse R.H. Nielsen -Michael Starzinger -Toon Verwaest -Vyacheslav Egorov -Yang Guo diff --git a/AUTHORS b/AUTHORS index 8b6045de4dfc5d..a5846107034244 100644 --- a/AUTHORS +++ b/AUTHORS @@ -149,6 +149,7 @@ Theo Schlossnagle Kai Chen Daniel Chcouri <333222@gmail.com> Mihai Călin Bazon +Kevin Millikin Ali Farhadi Daniel Ennis Carter Allen @@ -198,6 +199,7 @@ Kip Gebhardt Stefan Rusu Shigeki Ohtsu Wojciech Wnętrzak +Vyacheslav Egorov Devon Govett Steve Engledow Pierre-Alexandre St-Jean @@ -219,6 +221,7 @@ Antranig Basman Maciej Małecki Evan Martin Peter Lyons +Jakob Kummerow Jann Horn Abimanyu Raja Karl Skomski @@ -308,10 +311,12 @@ Farid Neshat Johannes Wüller Erik Lundin Bryan Cantrill +Michael Starzinger Yosef Dinerstein Nathan Friedly Aaron Jacobs Mustansir Golawala +Lasse R.H. Nielsen Atsuo Fukaya Domenic Denicola Joshua S. Weinstein @@ -328,6 +333,7 @@ J. Lee Coltrane Javier Hernández James Koval Kevin Gadd +Yang Guo Ray Solomon Kevin Bowman Erwin van der Koogh @@ -336,8 +342,11 @@ Simon Sturmer Joel Brandt Marc Harter Nuno Job +Daniel Clifford Ben Kelly Felix Böhm +Erik Corry +Toon Verwaest George Shank Gabriel de Perthuis Vladimir Beloborodov @@ -522,6 +531,7 @@ Lorenz Leutgeb ayanamist gluxon Tom Gallacher +Sven Panne Jo Liss Jun Ma Jacob Hoffman-Andrews @@ -542,6 +552,7 @@ Saúl Ibarra Corretgé Greg Brail Shuhei Kagawa Josh Dague +Dan Carney Goh Yisheng (Andrew) James Pickard Andrew Low @@ -564,6 +575,7 @@ Greg Sabia Tucker Dan Kaplun Colin Ihrig Mark Stosberg +Jochen Eisinger Calvin Metcalf Ryan Cole Kevin Decker @@ -1001,6 +1013,7 @@ Ingvar Stepanyan Adrian Estrada Matt Lavin Joao Andrade +Pavel Feldman Bartosz Sosnowski Nicolas Romer David A. Wheeler @@ -1040,12 +1053,14 @@ Joe Esposito Erin Spiceland Ravindra Barthwal Joey Cozza +Franziska Hinkelmann Vladimir de Turckheim Taehee Kang Igor Savin Pat Pannuto Haojian Wu John Gardner +Enrico Pertoso Aleksei Koziatinskii Adrian Nitu Ben Gourley @@ -1092,6 +1107,7 @@ Tarjei Husøy Wietse Venema Jonathan Prince Fikret Burak Gazioglu +Aleksey Kozyatinskiy delvedor Jermaine Oppong Richard Walker @@ -1540,6 +1556,7 @@ Ezequiel Garcia Kyle Farnung Weijia Wang Nataly Shrits +Oliver Chang Jaime Bernardo Natanael Log Chen Gang @@ -1551,6 +1568,7 @@ Jimmy Thomson David Drysdale Roman Shoryn Peter Czibik +Igor Sheludko 章礼平 Fraser Xu Song, Bintao Garfield @@ -1600,7 +1618,6 @@ Shivanth MP erdun <494251936@qq.com> Jiajie Hu Matt Woicik -Franziska Hinkelmann alexbostock Matthew Alsup Greg Alexander @@ -1848,6 +1865,7 @@ Luke Childs Robert Nagy Nikki St Onge zhangzifa +Tobias Tebbi hwaisiu Thomas Karsten Lance Barlaan @@ -1869,6 +1887,7 @@ Tomoki Okahana Aayush Ahuja Paul Marion Camantigue Jayson D. Henkel +Ben Smith Nicolas 'Pixel' Noble Ashish Kaila c0b <14798161+c0b@users.noreply.github.com> @@ -2013,6 +2032,7 @@ spring_raining Hiromu Yoshiwara yuza yuko smatsu-hl +Hannes Payer Bamieh WhoMeNope Junichi Kajiwara @@ -2023,6 +2043,8 @@ Hannes Magnusson ChungNgoops Jose M. Palacios Diaz hmammedzadeh +Sergei Datsenko +Marja Hölttä IHsuan Francisco Gerardo Neri Andriano Shilo Mangam @@ -2057,6 +2079,7 @@ Salame William Todd Wong Mykola Bilochub Qingyan Li +Jinho Bang Sho Miyamoto 现充 furstenheim @@ -2106,6 +2129,7 @@ Eric Bickle Ujjwal Sharma Wei-Wei Wu Prateek Singh +Mythri Alle Ken Lin Piotr Grzesik Damien Simonin Feugas @@ -2161,6 +2185,7 @@ John Musgrave Dhansuhu Uzumaki Beni von Cheni Ilya Sotov +Ulan Degenbaev William Cohen Ajido kailash k yogeshwar @@ -2253,10 +2278,12 @@ Simionescu, Radu mariotsi prayag21 <10997858+prayag21@users.noreply.github.com> Bruno Pinho +Michael Achenbach Anto Aravinth Helio Frota <00hf11@gmail.com> Jacob Page sagulati +Gabriel Charette conectado Vitor Bruno de Oliveira Barth Christian Clauss @@ -2271,6 +2298,7 @@ Ouyang Yadong yahavfuchs Thomas Leah Musa Hamwala +Andrey Lushnikov James Bromwell Jeremy Apthorp Eugen Cazacu <32613393+oygen87@users.noreply.github.com> @@ -2282,6 +2310,7 @@ Dzmitry_Prudnikau Ian McKellar Jennifer Bland Kyle Fuller +Camillo Bruni Yongsheng Zhang Neeraj Laad Scott Van Gilder @@ -2296,6 +2325,7 @@ Szymon Marczak Tessei Kameyama Chakravarthy S M Andreas Haas +Clemens Hammacher Saud Khanzada Hariss096 William Skellenger @@ -2672,6 +2702,7 @@ toshi1127 nd-02110114 dkundel Evan Plaice +Simon Zünd simon3000 Marcos Casagrande Ruwan Geeganage @@ -2844,6 +2875,7 @@ Patrick Housley Artem Maksimov Nolik palmires +Clemens Backes Vadim Gorbachev galina.prokofeva Nadya @@ -3032,6 +3064,7 @@ Karol Walasek osher szTheory Jonathan Buhacoff +Shu-yu Guo Paolo Insogna Richard Townsend Deep310 <55121371+Deep310@users.noreply.github.com> @@ -3113,6 +3146,7 @@ Hussaina Begum Nandyala Danny Sonnenschein Sourav Shaw H Adinarayana +Kim-Anh Tran lucasg Brian 'bdougie' Douglas Lee, Bonggi @@ -3320,6 +3354,7 @@ Ignacio Carbajo Constantine Kim OliverOdo Mark Skelton +Ross McIlroy Isaac Brodsky simon-id Francesco Trotta diff --git a/tools/update-authors.js b/tools/update-authors.js index 1eae7b61a83be4..f9f338464abd68 100755 --- a/tools/update-authors.js +++ b/tools/update-authors.js @@ -110,9 +110,7 @@ rl.on('line', (line) => { ({ author, email } = { author, email, ...replacement }); } - if (seen.has(email) || - /@chromium\.org/.test(email) || - email === '') { + if (seen.has(email)) { return; }