lib: make isStackOverflowError() engine-agnostic

Assumption that stack overflow exception has name == "RangeError" is v8-specific. Updated logic to dynamically capture error name when capturing error message. PR-URL: #19705 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 3, 2018 · 152a86c · 152a86c
1 parent e44b777
commit 152a86c
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -445,25 +445,29 @@ function dnsException(err, syscall, hostname) {
   return ex;
 }
 
-let MAX_STACK_MESSAGE;
+let maxStack_ErrorName;
+let maxStack_ErrorMessage;
 /**
- * Returns true if `err` is a `RangeError` with an engine-specific message.
+ * Returns true if `err.name` and `err.message` are equal to engine-specific
+ * values indicating max call stack size has been exceeded.
  * "Maximum call stack size exceeded" in V8.
  *
  * @param {Error} err
  * @returns {boolean}
  */
 function isStackOverflowError(err) {
-  if (MAX_STACK_MESSAGE === undefined) {
+  if (maxStack_ErrorMessage === undefined) {
     try {
       function overflowStack() { overflowStack(); }
       overflowStack();
     } catch (err) {
-      MAX_STACK_MESSAGE = err.message;
+      maxStack_ErrorMessage = err.message;
+      maxStack_ErrorName = err.name;
     }
   }
 
-  return err.name === 'RangeError' && err.message === MAX_STACK_MESSAGE;
+  return err.name === maxStack_ErrorName &&
+         err.message === maxStack_ErrorMessage;
 }
 
 module.exports = exports = {