assert: remove assert.snapshot

PR-URL: #46112 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
nodejs · Jan 31, 2023 · 1352f08 · 1352f08
1 parent 1834e94
commit 1352f08
Show file tree

Hide file tree

Showing 22 changed files with 6 additions and 405 deletions.
diff --git a/doc/api/assert.md b/doc/api/assert.md
@@ -2089,48 +2089,6 @@ argument, then `error` is assumed to be omitted and the string will be used for
 example in [`assert.throws()`][] carefully if using a string as the second
 argument gets considered.
 
-## `assert.snapshot(value, name)`
-
-<!-- YAML
-added: v18.8.0
--->
-
-> Stability: 1 - Experimental
-
-* `value` {any} the value to snapshot.
-* `name` {string} the name of the snapshot.
-* Returns: {Promise}
-
-Reads the `name` snapshot from a file and compares `value` to the snapshot.
-`value` is serialized with [`util.inspect()`][]. If the value is not strictly
-equal to the snapshot, `assert.snapshot()` returns a rejected `Promise` with an
-[`AssertionError`][].
-
-The snapshot filename uses the same basename as the application's main
-entrypoint with a `.snapshot` extension. If the snapshot file does not exist,
-it is created. The [`--update-assert-snapshot`][] command line flag can be used
-to force the update of an existing snapshot.
-
-```mjs
-import assert from 'node:assert/strict';
-
-// Assuming that the application's main entrypoint is app.mjs, this reads the
-// 'snapshotName' snapshot from app.snapshot and strictly compares its value
-// to `util.inspect('value')`.
-await assert.snapshot('value', 'snapshotName');
-```
-
-```cjs
-const assert = require('node:assert/strict');
-
-(async () => {
-  // Assuming that the application's main entrypoint is app.js, this reads the
-  // 'snapshotName' snapshot from app.snapshot and strictly compares its value
-  // to `util.inspect('value')`.
-  await assert.snapshot('value', 'snapshotName');
-})();
-```
-
 ## `assert.strictEqual(actual, expected[, message])`
 
 <!-- YAML
@@ -2567,7 +2525,6 @@ argument.
 [Object wrappers]: https://developer.mozilla.org/en-US/docs/Glossary/Primitive#Primitive_wrapper_objects_in_JavaScript
 [Object.prototype.toString()]: https://tc39.github.io/ecma262/#sec-object.prototype.tostring
 [`!=` operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Inequality
-[`--update-assert-snapshot`]: cli.md#--update-assert-snapshot
 [`===` operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality
 [`==` operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Equality
 [`AssertionError`]: #class-assertassertionerror
@@ -2599,6 +2556,5 @@ argument.
 [`process.on('exit')`]: process.md#event-exit
 [`tracker.calls()`]: #trackercallsfn-exact
 [`tracker.verify()`]: #trackerverify
-[`util.inspect()`]: util.md#utilinspectobject-options
 [enumerable "own" properties]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Enumerability_and_ownership_of_properties
 [prototype-spec]: https://tc39.github.io/ecma262/#sec-ordinary-object-internal-methods-and-internal-slots
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -1490,14 +1490,6 @@ occurs. One of the following modes can be chosen:
 If a rejection happens during the command line entry point's ES module static
 loading phase, it will always raise it as an uncaught exception.
 
-### `--update-assert-snapshot`
-
-<!-- YAML
-added: v18.8.0
--->
-
-Updates snapshot files used by [`assert.snapshot()`][].
-
 ### `--use-bundled-ca`, `--use-openssl-ca`
 
 <!-- YAML
@@ -1917,7 +1909,6 @@ Node.js options that are allowed are:
 * `--trace-warnings`
 * `--track-heap-objects`
 * `--unhandled-rejections`
-* `--update-assert-snapshot`
 * `--use-bundled-ca`
 * `--use-largepages`
 * `--use-openssl-ca`
@@ -2294,7 +2285,6 @@ done
 [`NO_COLOR`]: https://no-color.org
 [`SlowBuffer`]: buffer.md#class-slowbuffer
 [`YoungGenerationSizeFromSemiSpaceSize`]: https://chromium.googlesource.com/v8/v8.git/+/refs/tags/10.3.129/src/heap/heap.cc#328
-[`assert.snapshot()`]: assert.md#assertsnapshotvalue-name
 [`dns.lookup()`]: dns.md#dnslookuphostname-options-callback
 [`dns.setDefaultResultOrder()`]: dns.md#dnssetdefaultresultorderorder
 [`dnsPromises.lookup()`]: dns.md#dnspromiseslookuphostname-options

diff --git a/doc/api/errors.md b/doc/api/errors.md
@@ -705,13 +705,6 @@ A special type of error that can be triggered whenever Node.js detects an
 exceptional logic violation that should never occur. These are raised typically
 by the `node:assert` module.
 
-<a id="ERR_ASSERT_SNAPSHOT_NOT_SUPPORTED"></a>
-
-### `ERR_ASSERT_SNAPSHOT_NOT_SUPPORTED`
-
-An attempt was made to use `assert.snapshot()` in an environment that
-does not support snapshots, such as the REPL, or when using `node --eval`.
-
 <a id="ERR_ASYNC_CALLBACK"></a>
 
 ### `ERR_ASYNC_CALLBACK`

diff --git a/doc/node.1 b/doc/node.1
@@ -491,9 +491,6 @@ Track heap object allocations for heap snapshots.
 .It Fl -unhandled-rejections=mode
 Define the behavior for unhandled rejections. Can be one of `strict` (raise an error), `warn` (enforce warnings) or `none` (silence warnings).
 .
-.It Fl -update-assert-snapshot
-Updates snapshot files used by `assert.snapshot()`.
-.
 .It Fl -use-bundled-ca , Fl -use-openssl-ca
 Use bundled Mozilla CA store as supplied by current Node.js version or use OpenSSL's default CA store.
 The default store is selectable at build-time.

diff --git a/lib/assert.js b/lib/assert.js
@@ -1052,9 +1052,6 @@ assert.doesNotMatch = function doesNotMatch(string, regexp, message) {
 
 assert.CallTracker = CallTracker;
 
-const snapshot = require('internal/assert/snapshot');
-assert.snapshot = snapshot;
-
 /**
  * Expose a strict only variant of assert.
  * @param {...any} args

diff --git a/lib/internal/assert/snapshot.js b/lib/internal/assert/snapshot.js
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -962,8 +962,6 @@ module.exports = {
 E('ERR_AMBIGUOUS_ARGUMENT', 'The "%s" argument is ambiguous. %s', TypeError);
 E('ERR_ARG_NOT_ITERABLE', '%s must be iterable', TypeError);
 E('ERR_ASSERTION', '%s', Error);
-E('ERR_ASSERT_SNAPSHOT_NOT_SUPPORTED',
-  'Snapshot is not supported in this context ', TypeError);
 E('ERR_ASYNC_CALLBACK', '%s must be a function', TypeError);
 E('ERR_ASYNC_TYPE', 'Invalid name for async "type": %s', TypeError);
 E('ERR_BROTLI_INVALID_PARAM', '%s is not a valid Brotli parameter', RangeError);

diff --git a/src/node_options.cc b/src/node_options.cc
@@ -659,11 +659,6 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             &EnvironmentOptions::force_repl);
   AddAlias("-i", "--interactive");
 
-  AddOption("--update-assert-snapshot",
-            "update assert snapshot files",
-            &EnvironmentOptions::update_assert_snapshot,
-            kAllowedInEnvironment);
-
   AddOption("--napi-modules", "", NoOp{}, kAllowedInEnvironment);
 
   AddOption("--tls-keylog",

diff --git a/src/node_options.h b/src/node_options.h
@@ -139,7 +139,6 @@ class EnvironmentOptions : public Options {
   bool preserve_symlinks = false;
   bool preserve_symlinks_main = false;
   bool prof_process = false;
-  bool update_assert_snapshot = false;
 #if HAVE_INSPECTOR
   std::string cpu_prof_dir;
   static const uint64_t kDefaultCpuProfInterval = 1000;

diff --git a/test/fixtures/assert-snapshot/basic.mjs b/test/fixtures/assert-snapshot/basic.mjs
diff --git a/test/fixtures/assert-snapshot/multiple.mjs b/test/fixtures/assert-snapshot/multiple.mjs
diff --git a/test/fixtures/assert-snapshot/non-existing-name.mjs b/test/fixtures/assert-snapshot/non-existing-name.mjs
diff --git a/test/fixtures/assert-snapshot/non-existing-name.snapshot b/test/fixtures/assert-snapshot/non-existing-name.snapshot
diff --git a/test/fixtures/assert-snapshot/random.mjs b/test/fixtures/assert-snapshot/random.mjs
diff --git a/test/fixtures/assert-snapshot/random.snapshot b/test/fixtures/assert-snapshot/random.snapshot
diff --git a/test/fixtures/assert-snapshot/serialize.mjs b/test/fixtures/assert-snapshot/serialize.mjs
diff --git a/test/fixtures/assert-snapshot/serialize.snapshot b/test/fixtures/assert-snapshot/serialize.snapshot
diff --git a/test/fixtures/assert-snapshot/single.mjs b/test/fixtures/assert-snapshot/single.mjs
diff --git a/test/fixtures/assert-snapshot/value-changed.mjs b/test/fixtures/assert-snapshot/value-changed.mjs
diff --git a/test/fixtures/assert-snapshot/value-changed.snapshot b/test/fixtures/assert-snapshot/value-changed.snapshot