stream: sync stream unpipe resume

pipe() ondata should not control flow state if cleaned up.

Fixes: #31190

Backport-PR-URL: #32264
PR-URL: #31191
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #32264

Author: ronag

Diff for: lib/_stream_readable.js

@@ -705,6 +705,9 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
         debug('false write response, pause', state.awaitDrain);
         state.awaitDrain++;
       }
+      if (!cleanedUp) {
+        src.pause();
+      }
       if (!ondrain) {
         // When the dest drains, it reduces the awaitDrain counter
         // on the source.  This would be more elegant with a .once()
@@ -713,7 +716,6 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
         ondrain = pipeOnDrain(src);
         dest.on('drain', ondrain);
       }
-      src.pause();
     }
   }
 

Diff for: test/parallel/test-stream-readable-unpipe-resume.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const common = require('../common');
+const stream = require('stream');
+const fs = require('fs');
+
+const readStream = fs.createReadStream(process.execPath);
+
+const transformStream = new stream.Transform({
+  transform: common.mustCall(() => {
+    readStream.unpipe();
+    readStream.resume();
+  })
+});
+
+readStream.on('end', common.mustCall());
+
+readStream
+  .pipe(transformStream)
+  .resume();