benchmark: remove needless RegExp capturing

Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterwards at all; * some of the later captured groups are not used afterwards. PR-URL: #13718 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jun 21, 2017 · 11f4562 · 11f4562
1 parent d4a05b2
commit 11f4562
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/benchmark/common.js b/benchmark/common.js
@@ -217,7 +217,7 @@ function formatResult(data) {
   }
 
   var rate = data.rate.toString().split('.');
-  rate[0] = rate[0].replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1,');
+  rate[0] = rate[0].replace(/(\d)(?=(?:\d\d\d)+(?!\d))/g, '$1,');
   rate = (rate[1] ? rate.join('.') : rate[0]);
   return `${data.name}${conf}: ${rate}`;
 }

diff --git a/benchmark/run.js b/benchmark/run.js
@@ -60,7 +60,7 @@ if (format === 'csv') {
       console.log(`"${data.name}", "${conf}", ${data.rate}, ${data.time}`);
     } else {
       var rate = data.rate.toString().split('.');
-      rate[0] = rate[0].replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1,');
+      rate[0] = rate[0].replace(/(\d)(?=(?:\d\d\d)+(?!\d))/g, '$1,');
       rate = (rate[1] ? rate.join('.') : rate[0]);
       console.log(`${data.name} ${conf}: ${rate}`);
     }