test: deflake test-http-dump-req-when-res-ends.js

On some platforms the `'end'` event might not be emitted because the socket could be destroyed by the other peer while the client is still sending the data triggering an error. Use the `'close'` event instead. PR-URL: #30360 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Nov 17, 2019 · 109da52 · 109da52
1 parent e4a296c
commit 109da52
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -19,8 +19,6 @@ test-worker-memory: PASS,FLAKY
 test-http2-client-upload: PASS,FLAKY
 # https://github.com/nodejs/node/issues/20750
 test-http2-client-upload-reject: PASS,FLAKY
-# https://github.com/nodejs/node/issues/30011
-test-http-dump-req-when-res-ends: PASS,FLAKY
 
 [$system==linux]
 

diff --git a/test/parallel/test-http-dump-req-when-res-ends.js b/test/parallel/test-http-dump-req-when-res-ends.js
@@ -48,8 +48,12 @@ server.listen(0, mustCall(function() {
 
     res.resume();
 
-    // Wait for the response.
-    res.on('end', function() {
+    // On some platforms the `'end'` event might not be emitted because the
+    // socket could be destroyed by the other peer while data is still being
+    // sent. In this case the 'aborted'` event is emitted instead of `'end'`.
+    // `'close'` is used here because it is always emitted and does not
+    // invalidate the test.
+    res.on('close', function() {
       server.close();
     });
   }));