Skip to content

Commit

Permalink
src: remove calls to deprecated V8 functions (Equals)
Browse files Browse the repository at this point in the history
Remove all calls to deprecated V8 functions (here: Value::Equals)
inside the code.

PR-URL: #22665
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
targos committed Sep 5, 2018
1 parent c4ef170 commit 1025868
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/process_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ class ProcessWrap : public HandleWrap {
Local<Value> type =
stdio->Get(context, env->type_string()).ToLocalChecked();

if (type->Equals(env->ignore_string())) {
if (type->StrictEquals(env->ignore_string())) {
options->stdio[i].flags = UV_IGNORE;
} else if (type->Equals(env->pipe_string())) {
} else if (type->StrictEquals(env->pipe_string())) {
options->stdio[i].flags = static_cast<uv_stdio_flags>(
UV_CREATE_PIPE | UV_READABLE_PIPE | UV_WRITABLE_PIPE);
Local<String> handle_key = env->handle_string();
Expand All @@ -121,7 +121,7 @@ class ProcessWrap : public HandleWrap {
options->stdio[i].data.stream =
reinterpret_cast<uv_stream_t*>(
Unwrap<PipeWrap>(handle)->UVHandle());
} else if (type->Equals(env->wrap_string())) {
} else if (type->StrictEquals(env->wrap_string())) {
Local<String> handle_key = env->handle_string();
Local<Object> handle =
stdio->Get(context, handle_key).ToLocalChecked().As<Object>();
Expand Down

0 comments on commit 1025868

Please sign in to comment.