tls: destroy TLS socket if StreamWrap is destroyed

Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]>
nodejs · Jan 29, 2019 · 0f6a952 · 0f6a952
1 parent 0c73221
commit 0f6a952
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -310,10 +310,12 @@ function TLSSocket(socket, opts) {
 
   // Wrap plain JS Stream into StreamWrap
   var wrap;
-  if ((socket instanceof net.Socket && socket._handle) || !socket)
+  if ((socket instanceof net.Socket && socket._handle) || !socket) {
     wrap = socket;
-  else
+  } else {
     wrap = new StreamWrap(socket);
+    wrap.once('close', () => this.destroy());
+  }
 
   // Just a documented property to make secure sockets
   // distinguishable from regular ones.