Revert "readline: clean up event listener in onNewListener"

This reverts commit 81ddeb9. Ref: #13266 PR-URL: #13560 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Jun 10, 2017 · 0df6c0b · 0df6c0b
1 parent 53ec50d
commit 0df6c0b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -1039,9 +1039,6 @@ function emitKeypressEvents(stream, iface) {
   } else {
     stream.on('newListener', onNewListener);
   }
-  if (iface) {
-    iface.once('close', () => { stream.removeListener('data', onData); });
-  }
 }
 
 /**

diff --git a/test/parallel/test-readline-set-raw-mode.js b/test/parallel/test-readline-set-raw-mode.js
@@ -74,8 +74,6 @@ assert(!rawModeCalled);
 assert(resumeCalled);
 assert(!pauseCalled);
 
-// One data listener for the keypress events.
-assert.strictEqual(stream.listeners('data').length, 1);
 
 // close() should call setRawMode(false)
 expectedRawMode = false;
@@ -88,5 +86,5 @@ assert(!resumeCalled);
 assert(pauseCalled);
 
 assert.deepStrictEqual(stream.listeners('keypress'), []);
-// Data listener is removed once interface is closed.
-assert.strictEqual(stream.listeners('data').length, 0);
+// one data listener for the keypress events.
+assert.strictEqual(stream.listeners('data').length, 1);