test: add hasIntl to failing test

Currently when node is configured --without-intl the tests in this commit fail. This commit adds checks for internationalization for these tests PR-URL: #13699 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 21, 2017 · 0d3b52e · 0d3b52e
1 parent 61714ac
commit 0d3b52e
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 2 deletions.
diff --git a/test/common/README.md b/test/common/README.md
@@ -111,6 +111,11 @@ Checks `hasCrypto` and `crypto` with fips.
 
 Checks if [internationalization] is supported.
 
+### hasSmallICU
+* return [&lt;Boolean>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Boolean_type)
+
+Checks `hasIntl` and `small-icu` is supported.
+
 ### hasIPv6
 * return [&lt;Boolean>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Boolean_type)
 

diff --git a/test/common/index.js b/test/common/index.js
@@ -689,6 +689,12 @@ Object.defineProperty(exports, 'hasIntl', {
   }
 });
 
+Object.defineProperty(exports, 'hasSmallICU', {
+  get: function() {
+    return process.binding('config').hasSmallICU;
+  }
+});
+
 // Useful for testing expected internal/error objects
 exports.expectsError = function expectsError({code, type, message}) {
   return function(error) {

diff --git a/test/parallel/test-icu-data-dir.js b/test/parallel/test-icu-data-dir.js
@@ -1,5 +1,9 @@
 'use strict';
-require('../common');
+const common = require('../common');
+if (!(common.hasIntl && common.hasSmallICU)) {
+  common.skip('missing Intl');
+  return;
+}
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 

diff --git a/test/parallel/test-url-domain-ascii-unicode.js b/test/parallel/test-url-domain-ascii-unicode.js
@@ -1,6 +1,10 @@
 'use strict';
 
-require('../common');
+const common = require('../common');
+if (!common.hasIntl) {
+  common.skip('missing Intl');
+  return;
+}
 const strictEqual = require('assert').strictEqual;
 const url = require('url');
 

diff --git a/test/parallel/test-url-format-whatwg.js b/test/parallel/test-url-format-whatwg.js
@@ -1,6 +1,10 @@
 'use strict';
 
 const common = require('../common');
+if (!common.hasIntl) {
+  common.skip('missing Intl');
+  return;
+}
 const assert = require('assert');
 const url = require('url');
 const URL = url.URL;