lib: replace WeakMap global by the primordials

PR-URL: #31158 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Jan 6, 2020 · 0b8eaf2 · 0b8eaf2
1 parent 1527796
commit 0b8eaf2
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 0 deletions.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -29,6 +29,8 @@ rules:
       message: "Use `const { Reflect } = primordials;` instead of the global."
     - name: Symbol
       message: "Use `const { Symbol } = primordials;` instead of the global."
+    - name: WeakMap
+      message: "Use `const { WeakMap } = primordials;` instead of the global."
   no-restricted-syntax:
     # Config copied from .eslintrc.js
     - error

diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -17,6 +17,7 @@ const {
   ReflectOwnKeys,
   Symbol,
   SymbolHasInstance,
+  WeakMap,
 } = primordials;
 
 const { trace } = internalBinding('trace_events');

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -18,6 +18,7 @@ const {
   ObjectKeys,
   Symbol,
   SymbolFor,
+  WeakMap,
 } = primordials;
 
 const messages = new Map();

diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
@@ -2,6 +2,7 @@
 
 const {
   ObjectDefineProperty,
+  WeakMap,
 } = primordials;
 
 const {

diff --git a/lib/internal/source_map/source_map_cache.js b/lib/internal/source_map/source_map_cache.js
@@ -7,6 +7,7 @@ const {
   ObjectGetOwnPropertyDescriptor,
   ObjectPrototypeHasOwnProperty,
   MapPrototypeEntries,
+  WeakMap,
   WeakMapPrototypeGet,
   uncurryThis,
 } = primordials;

diff --git a/lib/internal/vm/module.js b/lib/internal/vm/module.js
@@ -7,6 +7,7 @@ const {
   ObjectDefineProperty,
   SafePromise,
   Symbol,
+  WeakMap,
 } = primordials;
 
 const { isContext } = internalBinding('contextify');
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     const {
       ObjectDefineProperty,
+      WeakMap,
     } = primordials;
     const {
@@ Expand Down @@