readline: emit key info unconditionally

Currently, 'keypress' events include the sequence and key info for named keys, but only the sequence for unnamed keys. This commit causes the key info to be included in both cases. PR-URL: #6024 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
nodejs · Apr 5, 2016 · 0a62f92 · 0a62f92
1 parent 3de9bc9
commit 0a62f92
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/internal/readline.js b/lib/internal/readline.js
@@ -384,9 +384,8 @@ function* emitKeys(stream) {
       stream.emit('keypress', escaped ? undefined : s, key);
     } else if (s.length === 1) {
       /* Single unnamed character, e.g. "." */
-      stream.emit('keypress', s);
-    } else {
-      /* Unrecognized or broken escape sequence, don't emit anything */
+      stream.emit('keypress', s, key);
     }
+    /* Unrecognized or broken escape sequence, don't emit anything */
   }
 }
diff --git a/test/parallel/test-readline-keys.js b/test/parallel/test-readline-keys.js
@@ -48,7 +48,7 @@ function addTest(sequences, expectedKeys) {
 addTest('io.JS', [
   { name: 'i', sequence: 'i' },
   { name: 'o', sequence: 'o' },
-  undefined, // emitted as `emit('keypress', '.', undefined)`
+  { name: undefined, sequence: '.' },
   { name: 'j', sequence: 'J', shift: true },
   { name: 's', sequence: 'S', shift: true },
 ]);