lib: avoid for of loop and remove unnecessary variable in zlib

removed the unnecessary declaration of 'i' in the _final method scope and changed the for of loop to a for loop Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration PR-URL: #54258 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Aug 14, 2024 · 09f411e · 09f411e
1 parent 6f4b5d9
commit 09f411e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -361,11 +361,10 @@ ZlibBase.prototype._final = function(callback) {
 // Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
 //     Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
 const flushiness = [];
-let i = 0;
 const kFlushFlagList = [Z_NO_FLUSH, Z_BLOCK, Z_PARTIAL_FLUSH,
                         Z_SYNC_FLUSH, Z_FULL_FLUSH, Z_FINISH];
-for (const flushFlag of kFlushFlagList) {
-  flushiness[flushFlag] = i++;
+for (let i = 0; i < kFlushFlagList.length; i++) {
+  flushiness[kFlushFlagList[i]] = i;
 }
 
 function maxFlush(a, b) {