test: robust handling of env for npm-test-install

Currently we are overwriting the entire env object of the child-process spawned in `npm-test-install`. This commit alternatively clones the `process.env` object and modifies it with the neccessary changes before passing it the the spawned process. Fixes: #6736 PR-URL: #6797 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 2, 2016 · 08777c0 · 08777c0
1 parent 072c32f
commit 08777c0
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/test/parallel/test-npm-install.js b/test/parallel/test-npm-install.js
@@ -32,11 +32,12 @@ const pkgPath = path.join(common.tmpDir, 'package.json');
 
 fs.writeFileSync(pkgPath, pkgContent);
 
+const env = Object.create(process.env);
+env['PATH'] = path.dirname(process.execPath);
+
 const proc = spawn(process.execPath, args, {
   cwd: common.tmpDir,
-  env: {
-    PATH: path.dirname(process.execPath)
-  }
+  env: env
 });
 
 function handleExit(code, signalCode) {