test_runner: simplify test start time tracking

This commit simplifies the logic for tracking test start time. The start time is now set only when a test/suite begins running. If the test/suite never runs, a fallback is provided in postRun(). PR-URL: #52182 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
nodejs · May 3, 2024 · 07e4a42 · 07e4a42
1 parent 8ba308a
commit 07e4a42
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -454,7 +454,6 @@ class Test extends AsyncResource {
     }
 
     if (preventAddingSubtests) {
-      test.startTime = test.startTime || hrtime();
       test.fail(
         new ERR_TEST_FAILURE(
           'test could not be started because its parent finished',
@@ -484,7 +483,6 @@ class Test extends AsyncResource {
         kCancelledByParent,
       ),
     );
-    this.startTime = this.startTime || this.endTime; // If a test was canceled before it was started, e.g inside a hook
     this.cancelled = true;
     this.abortController.abort();
   }
@@ -700,12 +698,13 @@ class Test extends AsyncResource {
   }
 
   postRun(pendingSubtestsError) {
+    this.startTime ??= hrtime();
+
     // If the test was failed before it even started, then the end time will
     // be earlier than the start time. Correct that here.
     if (this.endTime < this.startTime) {
       this.endTime = hrtime();
     }
-    this.startTime ??= this.endTime;
 
     // The test has run, so recursively cancel any outstanding subtests and
     // mark this test as failed if any subtests failed.

diff --git a/test/fixtures/test-runner/output/hooks_spec_reporter.snapshot b/test/fixtures/test-runner/output/hooks_spec_reporter.snapshot
@@ -11,10 +11,10 @@
 
  describe hooks - no subtests (*ms)
  before throws
-   1
+   1 (*ms)
     'test did not finish before its parent and was cancelled'
 
-   2
+   2 (*ms)
     'test did not finish before its parent and was cancelled'
 
  before throws (*ms)
@@ -390,7 +390,7 @@
 
  - after() called
  run after when before throws
-   1
+   1 (*ms)
     'test did not finish before its parent and was cancelled'
 
  run after when before throws (*ms)
@@ -422,11 +422,11 @@
  failing tests:
 
 *
- 1
+ 1 (*ms)
   'test did not finish before its parent and was cancelled'
 
 *
- 2
+ 2 (*ms)
   'test did not finish before its parent and was cancelled'
 
 *
@@ -772,7 +772,7 @@
       *
 
 *
- 1
+ 1 (*ms)
   'test did not finish before its parent and was cancelled'
 
 *