promise: hard deprecation for unhandled promise rejection

PR-URL: #8217 Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
nodejs · Aug 29, 2016 · 07dbf73 · 07dbf73
1 parent ecf474c
commit 07dbf73
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
@@ -45,6 +45,7 @@ function setupPromises(scheduleMicrotasks) {
     }
   }
 
+  var deprecationWarned = false;
   function emitPendingUnhandledRejections() {
     let hadListeners = false;
     while (pendingUnhandledRejections.length > 0) {
@@ -59,6 +60,14 @@ function setupPromises(scheduleMicrotasks) {
           warning.name = 'UnhandledPromiseRejectionWarning';
           warning.id = uid;
           process.emitWarning(warning);
+          if (!deprecationWarned) {
+            deprecationWarned = true;
+            process.emitWarning(
+              'Unhandled promise rejections are deprecated. In the future, ' +
+              'promise rejections that are not handled will terminate the ' +
+              'Node.js process with a non-zero exit code.',
+              'DeprecationWarning');
+          }
         } else {
           hadListeners = true;
         }

diff --git a/test/parallel/test-promises-warning-on-unhandled-rejection.js b/test/parallel/test-promises-warning-on-unhandled-rejection.js
@@ -16,11 +16,14 @@ process.on('warning', common.mustCall((warning) => {
       assert(/Unhandled promise rejection/.test(warning.message));
       break;
     case 1:
+      assert.strictEqual(warning.name, 'DeprecationWarning');
+      break;
+    case 2:
       assert.strictEqual(warning.name, 'PromiseRejectionHandledWarning');
       assert(/Promise rejection was handled asynchronously/
         .test(warning.message));
   }
-}, 2));
+}, 3));
 
 const p = Promise.reject('This was rejected');
 setImmediate(common.mustCall(() => p.catch(() => {})));