Skip to content

Commit

Permalink
console: Add noop impls of methods required in spec
Browse files Browse the repository at this point in the history
  • Loading branch information
aks- committed Oct 21, 2015
1 parent a3b238a commit 07d4183
Show file tree
Hide file tree
Showing 3 changed files with 90 additions and 0 deletions.
18 changes: 18 additions & 0 deletions doc/api/console.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,24 @@ to the current position.
Similar to [assert.ok()][], but the error message is formatted as
`util.format(message...)`.

### Compatibility functions

NOTE: The following functions are defined for compatibility purpose, and are not expected to do anything

* `console.group`
* `console.groupCollapsed`
* `console.groupEnd`
* `console.clear`
* `console.count`
* `console.dirxml`
* `console.isIndependentlyComposed`
* `console.table`
* `console.profile`
* `console.profileEnd`
* `console.timeline`
* `console.timelineEnd`
* `console.timeStamp`

## Class: Console

<!--type=class-->
Expand Down
42 changes: 42 additions & 0 deletions lib/console.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,47 @@ Console.prototype.assert = function(expression) {
};


Console.prototype.group = noop;


Console.prototype.groupCollapsed = noop;


Console.prototype.groupEnd = noop;


Console.prototype.clear = noop;


Console.prototype.count = noop;


Console.prototype.dirxml = noop;


Console.prototype.isIndependentlyComposed = noop;


Console.prototype.table = noop;


Console.prototype.profile = noop;


Console.prototype.profileEnd = noop;


Console.prototype.timeline = noop;


Console.prototype.timelineEnd = noop;


Console.prototype.timeStamp = noop;


function noop() {}


module.exports = new Console(process.stdout, process.stderr);
module.exports.Console = Console;
30 changes: 30 additions & 0 deletions test/parallel/test-console.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,36 @@ assert.doesNotThrow(function() {
console.timeEnd('label');
});

assert.doesNotThrow(function() {
console.group('test');
console.groupEnd();
});

assert.doesNotThrow(function() {
console.groupCollapsed('test');
console.groupEnd();
});

assert.doesNotThrow(console.clear);

assert.doesNotThrow(console.count);

assert.doesNotThrow(console.dirxml);

assert.doesNotThrow(console.exception);

assert.doesNotThrow(console.isIndependentlyComposed);

assert.doesNotThrow(console.profile);

assert.doesNotThrow(console.profileEnd);

assert.doesNotThrow(console.timeline);

assert.doesNotThrow(console.timelineEnd);

assert.doesNotThrow(console.timeStamp);

// an Object with a custom .inspect() function
var custom_inspect = { foo: 'bar', inspect: function() { return 'inspect'; } };

Expand Down

0 comments on commit 07d4183

Please sign in to comment.