doc: support multidimensional arrays in type link

Currently, we have at least one multidimensional array in type signature: see `records` parameter in https://nodejs.org/api/dns.html#dns_dns_resolvetxt_hostname_callback Our type parser does not linkify these signatures properly. This PR tries to fix this. PR-URL: #16207 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
nodejs · Oct 18, 2017 · 0776c80 · 0776c80
1 parent 191e390
commit 0776c80
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tools/doc/type-parser.js b/tools/doc/type-parser.js
@@ -58,6 +58,8 @@ const typeMap = {
   'URLSearchParams': 'url.html#url_class_urlsearchparams'
 };
 
+const arrayPart = /(?:\[])+$/;
+
 module.exports = {
   toLink: function(typeInput) {
     const typeLinks = [];
@@ -69,12 +71,10 @@ module.exports = {
       if (typeText) {
         let typeUrl = null;
 
-        // To support type[], we store the full string and use
-        // the bracket-less version to lookup the type URL
+        // To support type[], type[][] etc., we store the full string
+        // and use the bracket-less version to lookup the type URL
         const typeTextFull = typeText;
-        if (/\[]$/.test(typeText)) {
-          typeText = typeText.slice(0, -2);
-        }
+        typeText = typeText.replace(arrayPart, '');
 
         const primitive = jsPrimitives[typeText.toLowerCase()];