Skip to content

Commit

Permalink
docs: remind backporter about v8_embedder_string
Browse files Browse the repository at this point in the history
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.
  • Loading branch information
kvakil committed Jul 21, 2022
1 parent dabda03 commit 066385f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions doc/contributing/maintaining-V8.md
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ Refs: https://github.com/v8/v8/commit/a51f429772d1e796744244128c9feeab4c26a854
PR-URL: https://github.com/nodejs/node/pull/7833
```

* Increase the `v8_embedder_string` number in `common.gypi`.
* Open a PR against the `v6.x-staging` branch in the Node.js repository. Launch
the normal and [V8 CI][] using the Node.js CI system. We only needed to
backport to `v6.x` as the other LTS branches weren't affected by this bug.
Expand Down

0 comments on commit 066385f

Please sign in to comment.