From 050866ddf19e745260c40a6763ed45a064d203e5 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 23 Jul 2020 12:00:41 -0700 Subject: [PATCH] doc: remove breaking-change-helper from onboarding-extras MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I don't think anyone uses the breaking change helper code that is in onboarding-extras. I'm not sure it works for us anyway as I think it will fail if there are any breaking changes since the last release. That may be helpful to releasers, but that is not helpful in determining if an individual commit is semver-major or not. Regardless, I don't think it gets used and I'm interested in not weighing down the onboarding process with a bunch of things that we don't actually use/do. PR-URL: https://github.com/nodejs/node/pull/34497 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Pranshu Srivastava Reviewed-By: Anto Aravinth --- doc/guides/onboarding-extras.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/doc/guides/onboarding-extras.md b/doc/guides/onboarding-extras.md index de7d230217b681..6904713ce7ed67 100644 --- a/doc/guides/onboarding-extras.md +++ b/doc/guides/onboarding-extras.md @@ -46,14 +46,6 @@ such as if CI run fails or a new outstanding review comment is posted. section to the docs" * major vs. everything else: run last versions tests against this version, if they pass, **probably** minor or patch - * A breaking change helper - ([full source](https://gist.github.com/chrisdickinson/ba532fa0e4e243fb7b44)): - - ```bash - SHOW=$(git show-ref -d $(git describe --abbrev=0) | tail -n1 | awk '{print $1}') - git checkout $(git show -s --pretty='%T' $SHOW) -- test - make -j4 test - ``` ### LTS/Version labels