http: don't emit error after destroy

PR-URL: #55457 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
nodejs · Dec 10, 2024 · 025f057 · 025f057
1 parent aa6b0e8
commit 025f057
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -908,6 +908,10 @@ OutgoingMessage.prototype.write = function write(chunk, encoding, callback) {
 };
 
 function onError(msg, err, callback) {
+  if (msg.destroyed) {
+    return;
+  }
+
   const triggerAsyncId = msg.socket ? msg.socket[async_id_symbol] : undefined;
   defaultTriggerAsyncIdScope(triggerAsyncId,
                              process.nextTick,
@@ -919,7 +923,7 @@ function onError(msg, err, callback) {
 
 function emitErrorNt(msg, err, callback) {
   callback(err);
-  if (typeof msg.emit === 'function' && !msg._closed) {
+  if (typeof msg.emit === 'function' && !msg.destroyed) {
     msg.emit('error', err);
   }
 }

diff --git a/test/parallel/test-http-outgoing-destroyed.js b/test/parallel/test-http-outgoing-destroyed.js
@@ -51,5 +51,27 @@ const assert = require('assert');
       .on('error', common.mustCall())
       .write('asd');
   });
+}
 
+{
+  const server = http.createServer(common.mustCall((req, res) => {
+    assert.strictEqual(res.closed, false);
+    res.end();
+    res.destroy();
+    // Make sure not to emit 'error' after .destroy().
+    res.end('asd');
+    assert.strictEqual(res.errored, undefined);
+  })).listen(0, () => {
+    http
+      .request({
+        port: server.address().port,
+        method: 'GET'
+      })
+      .on('response', common.mustCall((res) => {
+        res.resume().on('end', common.mustCall(() => {
+          server.close();
+        }));
+      }))
+      .end();
+  });
 }