worker: fix worker name with \0

Author: theanarkh

src/api/environment.cc

@@ -511,9 +511,17 @@ NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
 }
 
 NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
-    Environment* env, ThreadId thread_id, const char* url, const char* name) {
+  Environment* env,
+  ThreadId thread_id,
+  const char* url,
+  const char* name) {
+  std::string name_str(name);
+  return GetInspectorParentHandle(env, thread_id, url, name_str);
+}
+
+NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
+    Environment* env, ThreadId thread_id, const char* url, const std::string& name) {
   CHECK_NOT_NULL(env);
-  if (name == nullptr) name = "";
   CHECK_NE(thread_id.id, static_cast<uint64_t>(-1));
   if (!env->should_create_inspector()) {
     return nullptr;

src/node.h

@@ -703,6 +703,12 @@ NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
     const char* child_url,
     const char* name);
 
+NODE_EXTERN std::unique_ptr<InspectorParentHandle> GetInspectorParentHandle(
+  Environment* parent_env,
+  ThreadId child_thread_id,
+  const char* child_url,
+  const std::string& name);
+
 struct StartExecutionCallbackInfo {
   v8::Local<v8::Object> process_object;
   v8::Local<v8::Function> native_require;

src/node_worker.cc

@@ -93,7 +93,7 @@ Worker::Worker(Environment* env,
   if (env->permission()->is_granted(
           env, node::permission::PermissionScope::kInspector)) {
     inspector_parent_handle_ =
-        GetInspectorParentHandle(env, thread_id_, url.c_str(), name.c_str());
+        GetInspectorParentHandle(env, thread_id_, url.c_str(), name);
   }
 
   argv_ = std::vector<std::string>{env->argv()[0]};

test/parallel/test-worker-name.js

@@ -17,7 +17,7 @@ if (!isMainThread) {
 const assert = require('assert');
 
 if (isMainThread) {
-  const name = 'Hello Thread';
+  const name = 'Hello\0Thread';
   const expectedTitle = `[worker 1] ${name}`;
   const worker = new Worker(fixtures.path('worker-name.js'), {
     name,