test: account for pending deprecations in esm test

test-esm-local-deprecations fails if NODE_PENDING_DEPRECATION is set because the test expects exactly the warnings it expects and no other warnings. Modify the test to still expect its errors in the order it expects them, but to ignore errors it does not expect. PR-URL: #37542 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 2, 2021 · 00b3446 · 00b3446
1 parent d93137b
commit 00b3446
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/test/es-module/test-esm-local-deprecations.mjs b/test/es-module/test-esm-local-deprecations.mjs
@@ -1,4 +1,4 @@
-import { mustCall } from '../common/index.mjs';
+import '../common/index.mjs';
 import assert from 'assert';
 import fixtures from '../common/fixtures.js';
 import { pathToFileURL } from 'url';
@@ -9,15 +9,20 @@ const selfDeprecatedFolders =
 const deprecatedFoldersIgnore =
     fixtures.path('/es-modules/deprecated-folders-ignore/main.js');
 
-let curWarning = 0;
 const expectedWarnings = [
   '"./" in the "exports" field',
   '"#self/" in the "imports" field'
 ];
 
-process.addListener('warning', mustCall((warning) => {
-  assert(warning.stack.includes(expectedWarnings[curWarning++]), warning.stack);
-}, expectedWarnings.length));
+process.addListener('warning', (warning) => {
+  if (warning.stack.includes(expectedWarnings[0])) {
+    expectedWarnings.shift();
+  }
+});
+
+process.on('exit', () => {
+  assert.deepStrictEqual(expectedWarnings, []);
+});
 
 (async () => {
   await import(pathToFileURL(selfDeprecatedFolders));