-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-finalization-group-error failed on v8 8.4 #156
Comments
I debugged this, throw is triggered, but node-v8/test/parallel/test-finalization-group-error.js Lines 8 to 10 in e1230d5
|
Pretty sure this is because you need to change the flag to |
I am aware of that, when I debug, I add |
@syg could recent changes (maybe the torque rewrite?) have broken the uncaught exception reporting? there's been a similar issue with microtasks for a while. |
I debugged this locally. I noticed three issues with node's WeakRef integration. I'm not exactly sure how this test worked before.
Testing weak refs and finalizers is hard, good luck! |
This is made obsolete by nodejs/node#33373 which I cherry-picked to canary-base. |
This one still failed:
cc @mmarchini
Originally posted by @gengjiawen in #155 (comment)
The text was updated successfully, but these errors were encountered: