Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build failure #102

Closed
targos opened this issue Mar 31, 2019 · 5 comments
Closed

Windows build failure #102

targos opened this issue Mar 31, 2019 · 5 comments

Comments

@targos
Copy link
Member

targos commented Mar 31, 2019

https://ci.nodejs.org/job/node-compile-windows/25607/label=win-vs2017/console

08:45:56   mksnapshot.cc
08:46:11      Creating library c:\workspace\node-compile-windows\Release\mksnapshot.lib and object c:\workspace\node-compile-windows\Release\mksnapshot.exp
08:46:20   mksnapshot.vcxproj -> c:\workspace\node-compile-windows\Release\\mksnapshot.exe
08:46:20   generating: "Release\obj\generate_snapshot\/embedded.S" "Release\obj\generate_snapshot\/snapshot.cc"
08:46:22   Assembling Release\obj\generate_snapshot\\embedded.S...
08:46:22 Release\obj\generate_snapshot\\embedded.S(1): error A2008: syntax error : / [c:\workspace\node-compile-windows\tools\v8_gypfiles\generate_snapshot.vcxproj]
@refack
Copy link

refack commented Mar 31, 2019

Seems like the generator doesn't handle \ in paths:

.file 1 "....deps�8src�uiltins�ase.tq"

image

image

Where \b = \0x08

@refack
Copy link

refack commented Mar 31, 2019

std::replace(fixed_filename.begin(), fixed_filename.end(), '\\', '/');

This doesn't work as expected (and BTW this is C++20)

Now that I think of it this is probably related to nodejs/node#27017. This is a line from
global_intermediate\torque-output-root\torque-generated\builtins-array-from-dsl-gen.cc

    ca_.SetSourcePosition("..\..\deps\v8\src\builtins\array.tq", 20);

@refack
Copy link

refack commented Mar 31, 2019

Pushed a temporary patch as 42f8116
https://ci.nodejs.org/job/node-test-commit-node-v8/229/

@refack
Copy link

refack commented Mar 31, 2019

Ok, seems like we were missing another small thing

['OS=="win"', {
'defines': [ 'V8_TARGET_OS_WIN' ],
}],

17d955f

https://ci.nodejs.org/job/node-test-commit-windows-fanned/26076/

@refack
Copy link

refack commented Mar 31, 2019

Rebased 3c649ec...506610d
Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/26080/ ✔️

Pushed to nodejs/node/canary-base

@refack refack closed this as completed Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants