Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Deprecate smalloc in v0.12 #25784

Closed
Fishrock123 opened this issue Jul 30, 2015 · 6 comments
Closed

Deprecate smalloc in v0.12 #25784

Fishrock123 opened this issue Jul 30, 2015 · 6 comments

Comments

@Fishrock123
Copy link

With the converged release coming, smalloc will simply cease to exist altogether, since it is not possible to make it work with v8 4.4+.

As such, it may be prudent to issue a deprecation warning for it in node v0.12 since people may have not gotten the message from io.js yet.

However, there's no alternatives that work on v0.12 directly, since the final required typed array APIs were added in v8 4.3.

See IRC disscussion with @misterdjules: http://logs.libuv.org/io.js/latest#17:14:09.960

See the following io.js PRs:

  1. lib: deprecate the smalloc module node#1564
  2. Deprecate smalloc functions node#1565
  3. doc: deprecate smalloc module node#1566
  4. smalloc: deprecate whole module node#1822
  5. test: remove smalloc add-on test node#1835

cc @bnoordhuis, @trevnorris, etc

@trevnorris
Copy link

Unfortunately any deprecation will have to happen during the v0.12 release. We were going to do that for the v4.3 release, but took long enough that updated to v4.4.

If it's any consolation, it wasn't used heavily in the ecosystem. So deprecating it during v0.12 shouldn't cause much fuss.

@jasnell
Copy link
Member

jasnell commented Aug 3, 2015

+1 to marking this as clearly deprecated in v0.12. To be honest, it may even be a good idea to add a deprecation notice into v0.10 (at least in the documentation)

@Fishrock123
Copy link
Author

it may even be a good idea to add a deprecation notice into v0.10 (at least in the documentation)

Afaik, smalloc only came around in 0.12. 0.10 had a different thing: "SlowBuffer".

@trevnorris
Copy link

@Fishrock123 Node always had SlowBuffer. I just reused the name because it was mostly equivalent to what I used it for. But yes, it was only introduced in v0.12.

@jasnell
Copy link
Member

jasnell commented Aug 3, 2015

Ah right... forgot about that. Thanks for the reminder. :-)

@mhdawson
Copy link
Member

Discussed in latest LTS meeting and we are not going to get to this an its not that important to just going to close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants