-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Docs: C/C++ Links to node-postgress which is NOT v0.6.x compatible yet #2352
Comments
http://nodejs.org/docs/latest/api/addons.html ... "For the moment, that is all the documentation on addons. Please see https://github.com/ry/node_postgres for a real example." |
https://github.com/ry/node_postgres/blob/master/binding.cc hasn't been update since 2010! It has a 0% chance of compiling on node v0.6.x since the native EventEmitter class no longer even exists! |
I did a bunch of work on https://github.com/ddopson/node-zookeeper to update it to v0.6.x. I'm not sure I'd say it's a shining example of the pattern for building a node module, but it does work. |
https://github.com/astro/node-expat was updated in Aug 2011 (~4 mo ago) for v0.5.x compat. This would also be acceptable. |
I gave a presentation on node c++ modules not too long ago: https://github.com/shtylman/node-presentation (and the subsequent gh-pages branch: http://shtylman.github.com/node-presentation/#1). If that seems like generally good stuff I would be happy to provide documentation updates based on it. |
@shtylman: Yes, please. Can you stress in your async example that the work callback cannot use anything from or call into V8? |
@bnoordhuis Will do. Do you want the examples written up all on one page as it is now? Or broken up into sections? |
One page is fine but can you make it less presentation-y than http://shtylman.github.com/node-presentation/ ? :) |
@bnoordhuis yea. I will just move the relevant code and descriptions into the docs page with no "presentation-y" aspects :) |
If we are going to get some real attention on this, I'd be glad to contribute my own linguistic talents. Ideally, a discussion of native modules would cover the following:
|
@arturadib is working on some great add-on documentation in #2390. Let's continue the discussion there. |
this seems very broken. Pretty much the only documentation for writing a native module is a link to node-postgress. ..... which still uses the EventEmitter class that doesn't exist in node v0.6.x.
Either get node-postgress needs to be ported to node v0.6.x, or we should pick a new example.
The text was updated successfully, but these errors were encountered: