Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

benchmark / static_http_server.js doesn't work #2016

Closed
windyrobin opened this issue Nov 5, 2011 · 4 comments
Closed

benchmark / static_http_server.js doesn't work #2016

windyrobin opened this issue Nov 5, 2011 · 4 comments

Comments

@windyrobin
Copy link

@koichik

it uses methods like req.close or res.close
which should be req.end() and res.end();

@windyrobin
Copy link
Author

tested on node v0.5.10

@koichik
Copy link

koichik commented Nov 5, 2011

It has not been updated since March, 2010 (not 2011!).
Shoud we fix it? Who needs it?

@bnoordhuis
Copy link
Member

@koichik: It should either work or be removed. :)

I've pushed a fix in bnoordhuis/node@28fb244. I'll leave it up to you to decide if it's worthwhile to apply.

@koichik koichik closed this as completed in 1001cf4 Nov 5, 2011
@koichik
Copy link

koichik commented Nov 5, 2011

@windyrobin - Thanks for the report.
Now, static_http_server.js uses latest API such as http.get() and http.Agent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants