-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement node-gyp in pure javascript. #634
Comments
If you haven't, I suggest you take a look at what some of the Python code does. The code I looked at recently generates make files for nix and OSX and build files for Windows. This is very complicated, with a tremendous amount of arcane detail and edge cases. Also this code (at least what I looked at, here: https://github.com/TooTallNate/node-gyp/blob/master/gyp/pylib/gyp/generator/make.py) comes from Google so it's provenance is well known. In short, this is really hard to get right, other excellent engineers already got it right, and there would be no functional improvement to node-gyp to recreating this code. A dependency on Python (a fairly easy dependency to manage) is in my opinion a small price to pay for the tremendous value this code provides node-gyp. It's at the heart of what node-gyp does and node-gyp wouldn't work without it. |
@lygstate What you're asking is... easier said than done... |
I am not just saying, I am thinking about it. |
Related: nodejs/node#133 |
👍 I realize this is easier said than done, but it would be nice. Also, yaml based instead of the unpleasant format of the gyp files. |
For reference, node also requires python to be built. It's probably a topic that is best discussed around nodejs/node#133, but I'll leave this open also. |
At the current time, we need to dependence to python that's cause we always need to install python.
And gyp is pure JSON, maybe we can take advantage of that?
The text was updated successfully, but these errors were encountered: