Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find VC.Tools.ARM64 on arm64 machine #3075

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Find VC.Tools.ARM64 on arm64 machine #3075

wants to merge 6 commits into from

Conversation

saschanaz
Copy link

@saschanaz saschanaz commented Sep 30, 2024 •
edited
Loading

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

Fixes #3074

VC.Tools.ARM64 gives the native ARM64 binaries for MSVC, and this patch detects that on arm64 Node.js.

Help needed for a test. A fixture that only have ARM64 binary may work but such test would only pass on arm64 test runner machine. And not sure how to generate such fixture. (Just remove x86.x64 from the existing 2022 fixture?)

Also this patch makes some existing tests fail on ARM64 machine because not all fixtures have ARM64 MSVC (as older VS just didn't have it). Help needed for that too. Skip them somehow? Now it falls back to x86 if arm64 tool doesn't exist.

@saschanaz saschanaz marked this pull request as ready for review September 30, 2024 21:22
@StefanStojanovic
Copy link
Contributor

Hey @saschanaz thanks for this PR! macOS seems to be failing with these changes. Can you please investigate it and see why that is happening? Thanks in advance.

P.S. I remember this PR we had some time ago. Not sure it is connected to this but it also had some ARM64 specifics.

@saschanaz
Copy link
Author

Hey @saschanaz thanks for this PR! macOS seems to be failing with these changes. Can you please investigate it and see why that is happening? Thanks in advance.

P.S. I remember this PR we had some time ago. Not sure it is connected to this but it also had some ARM64 specifics.

That's exactly because what I said earlier:

Also this patch makes some existing tests fail on ARM64 machine because not all fixtures have ARM64 MSVC (as older VS just didn't have it). Help needed for that too. Skip them somehow?

@saschanaz
Copy link
Author

The last test failure seems irrelevant to my patch and more random?

@saschanaz
Copy link
Author

Three attempts failed, I wonder it passes on the main branch.

@StefanStojanovic
Copy link
Contributor

Three attempts failed, I wonder it passes on the main branch.

I ran those attempts. Just minutes ago, I thought to give it another chance before replying to this, and it has passed now.

StefanStojanovic
StefanStojanovic approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Would still like to see someone else take a look before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-gyp fails to detect ARM64 MSVC
2 participants
@saschanaz @StefanStojanovic