Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: add an arch check to VS 2019 #3025

Conversation

huseyinacacak-janea
Copy link
Contributor

Checklist
  • npm install && npm run lint && npm test passes
Description of change

The msbuildPath was wrong on ARM64 machines when Visual Studio 2019 was used. I've fixed this by using the corresponding path for the ARM64 machines if the Visual Studio version is 2019.

I also removed the workaround here: 0bab6a0#diff-c4ed6cb32588722371276d96a40ec39364f8c4a8ab39d9489cd5b939c05147b6

Fixes: #3014

@StefanStojanovic
Copy link
Contributor

GH action failure was unrelated, I reran it and now all is green.

@StefanStojanovic
Copy link
Contributor

If there are no objections until tomorrow, I'm going to land this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/test-find-visualstudio.js may fail on Windows on ARM
3 participants