Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I would like to specify <VCToolsVersion> #2906

Closed
tr-takatsuka opened this issue Sep 27, 2023 · 1 comment
Closed

I would like to specify <VCToolsVersion> #2906

tr-takatsuka opened this issue Sep 27, 2023 · 1 comment
Labels
Windows

Comments

@tr-takatsuka
Copy link

tr-takatsuka commented Sep 27, 2023 •
edited
Loading

  • Node Version: v18.11.0
  • Platform: Windows 11
  • Compiler: MSVC 2022
  • Module: -

Hello.

I would like to specify the detailed version of VisualC++ to be used in the build.
Currently, the latest MSVC Toolset installed in the environment is used.
The ability to insert <VCToolsVersion> into the .vcxproj output by node-gyp would be nice.

example

'configurations': {
  'Debug': {
    'msvs_settings': {
      'VCCLCompilerTool': {
         'VCToolsVersion': '14.36.32532',

Thank you in advance.
tr-takatsuka added a commit to tr-takatsuka/node-gyp that referenced this issue Oct 6, 2023
@tr-takatsuka
feat: add VCToolsVersion for msvs (nodejs#2906)
4bd032d
tr-takatsuka added a commit to tr-takatsuka/node-gyp that referenced this issue Oct 6, 2023
@tr-takatsuka
feat: add VCToolsVersion for msvs (nodejs#2906)
afcfd0a 
Allows "MSVC Toolset version" <VCToolsVersion> to be specified for VisualStudio platform.

Usage example for binding.gyp

```
'targets': [
 {
   'configurations': {
     'Debug': {
       "msvs_configuration_attributes": {
         "VCToolsVersion": "14.36.32532",
```
@StefanStojanovic
Copy link
Contributor

Closing this, since nodejs/gyp-next#209 landed. Thank you @tr-takatsuka for the initiative!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cclauss @StefanStojanovic @tr-takatsuka