fix: increase node 12 support to ^12.13 #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2772 addresses the test failures which are unrelated to the changes in this PR |
2 tasks
lukekarrys
force-pushed
the
node-12-engines
branch
from
3fa793a to
b69f80d
Compare
|
@cclauss thanks! how soon do you think a v9 patch release could be cut? |
ljharb
added a commit
to ljharb/aud
that referenced
this pull request
Dec 19, 2022
Fixed in node-gyp v9.3.1, in nodejs/node-gyp#2771 See: - npm/run-script#76 - npm/cli#5049 (comment)
ljharb
added a commit
to ljharb/npm-lockfile
that referenced
this pull request
Dec 19, 2022
Fixed in node-gyp v9.3.1, in nodejs/node-gyp#2771 See: - npm/run-script#76 - npm/cli#5049 (comment)
ljharb
added a commit
to ljharb/get-dep-tree
that referenced
this pull request
Dec 19, 2022
Fixed in node-gyp v9.3.1, in nodejs/node-gyp#2771 See: - npm/run-script#76 - npm/cli#5049 (comment)
ljharb
added a commit
to ljharb/ls-publishers
that referenced
this pull request
Dec 19, 2022
Fixed in node-gyp v9.3.1, in nodejs/node-gyp#2771 See: - npm/run-script#76 - npm/cli#5049 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
npm@8updated tonode-gyp@9which was technically a breaking change for us due to the mismatch of the lower bound of node 12 support. this was done by mistake but we opted not to revert since by the time we noticed we were more concerned that changing node-gyp versions would break more things.changing the lower bound of node 12 to 12.13 will align with npm 8 and allow us to fix our breaking change without needing to do a bunch of back ports.
Ref #2753 (comment)
Ref npm/cli#5049 (comment)