Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flake8 test for this repo #2487

Closed
gengjiawen opened this issue Aug 21, 2021 · 3 comments · Fixed by nodejs/gyp-next#122
Closed

disable flake8 test for this repo #2487

gengjiawen opened this issue Aug 21, 2021 · 3 comments · Fixed by nodejs/gyp-next#122

Comments

@gengjiawen
Copy link
Member

Should we add this rule in https://github.com/nodejs/gyp-next ?

Also should we disable flake8 test for this repo since gyp sources is an upstream project ?

@cclauss @rvagg

Originally posted by @gengjiawen in #2481 (comment)

@cclauss
Copy link
Contributor

cclauss commented Aug 21, 2021

Better safe than sorry. How long does a flake8 run take? If the run takes less than 5 minutes then I see no reason to eliminate it.

@gengjiawen
Copy link
Member Author

Better safe than sorry. How long does a flake8 run take? If the run takes less than 5 minutes then I see no reason to eliminate it.

The issue now is that rules on both side are not consistent. Works fine on gyp-next and breaks on this repo.

We may need to align the rules in the long run.

@cclauss
Copy link
Contributor

cclauss commented Aug 21, 2021

Put the rules in setup.cfg and copy that file when we copy the Python code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants