We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we add this rule in https://github.com/nodejs/gyp-next ?
Also should we disable flake8 test for this repo since gyp sources is an upstream project ?
@cclauss @rvagg
Originally posted by @gengjiawen in #2481 (comment)
The text was updated successfully, but these errors were encountered:
Better safe than sorry. How long does a flake8 run take? If the run takes less than 5 minutes then I see no reason to eliminate it.
Sorry, something went wrong.
The issue now is that rules on both side are not consistent. Works fine on gyp-next and breaks on this repo.
gyp-next
We may need to align the rules in the long run.
Put the rules in setup.cfg and copy that file when we copy the Python code.
setup.cfg
Successfully merging a pull request may close this issue.
Should we add this rule in https://github.com/nodejs/gyp-next ?
Also should we disable flake8 test for this repo since gyp sources is an upstream project ?
@cclauss @rvagg
Originally posted by @gengjiawen in #2481 (comment)
The text was updated successfully, but these errors were encountered: