Skip to content

Commit

Permalink
test: use Nan in duplicate_symbols
Browse files Browse the repository at this point in the history
Use `Nan::Set()` and `Nan::GetFunction()` instead of their V8
equivalents to avoid OSX test failures with Node.js v12.x.

Thanks @rvagg!

Re: nodejs/node-addon-api#456
Fixes: nodejs/node#26765
PR-URL: #1689
Reviewed-By: Rod Vagg <[email protected]>
  • Loading branch information
Gabriel Schulhof authored and rvagg committed Jun 21, 2019
1 parent f952b08 commit ec2eb44
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions test/node_modules/duplicate_symbols/binding.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/node_modules/duplicate_symbols/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ec2eb44

Please sign in to comment.