Commit c26ca1b

Gabriel Schulhof

authored and

committed

test: use Nan in duplicate_symbols

Use `Nan::Set()` and `Nan::GetFunction()` instead of their V8 equivalents to avoid OSX test failures with Node.js v12.x. Thanks @rvagg! Re: nodejs/node-addon-api#456 Fixes: nodejs/node#26765 PR-URL: #1689 Reviewed-By: Rod Vagg <[email protected]>

1 parent ef5354c commit c26ca1bCopy full SHA for c26ca1b

2 files changed

+4

-4

lines changed

test/node_modules/duplicate_symbols
- binding.cc
- package.json

2 files changed

+4

-4

lines changed

`‎test/node_modules/duplicate_symbols/binding.cc`

+3-3

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

`‎test/node_modules/duplicate_symbols/package.json`

+1-1

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Comments

(0)