Skip to content

Commit 1fe2902

Browse files
authored
Undefined name: cflags --> ldflags
@rvagg This would be good to land before #1892 The current code would raise NameError at runtime.
1 parent 2441932 commit 1fe2902

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gyp/pylib/gyp/xcode_emulation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ def GetLdflags(self, configname, product_dir, gyp_to_build_path, arch=None):
846846
if self._IsXCTest():
847847
platform_root = self._XcodePlatformPath(configname)
848848
if platform_root:
849-
cflags.append('-F' + platform_root + '/Developer/Library/Frameworks/') # noqa TODO @cclauss
849+
ldflags.append('-F' + platform_root + '/Developer/Library/Frameworks/')
850850

851851
is_extension = self._IsIosAppExtension() or self._IsIosWatchKitExtension()
852852
if sdk_root and is_extension:

0 commit comments

Comments
 (0)