gyp: list(dict) so we can del dict(key) while iterating

Fixes #1998 Reviewed-By: Rod Vagg <[email protected]> PR-URL: #2009
nodejs · Jan 6, 2020 · 14f2a07 · 14f2a07
1 parent 26cd6ea
commit 14f2a07
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/gyp/pylib/gyp/input.py b/gyp/pylib/gyp/input.py
@@ -2286,7 +2286,7 @@ def SetUpConfigurations(target, target_dict):
         merged_configurations[configuration])
 
   # Now drop all the abstract ones.
-  for configuration in target_dict['configurations'].keys():
+  for configuration in list(target_dict['configurations']):
     old_configuration_dict = target_dict['configurations'][configuration]
     if old_configuration_dict.get('abstract'):
       del target_dict['configurations'][configuration]