Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: Skip the wait check for specific PRs #94

Closed
2 tasks
Tiriel opened this issue Nov 7, 2017 · 5 comments
Closed
2 tasks

Todo: Skip the wait check for specific PRs #94

Tiriel opened this issue Nov 7, 2017 · 5 comments
Labels
feature request New features for node-core-utils

Comments

@Tiriel
Copy link
Contributor

Tiriel commented Nov 7, 2017

Hey!

Related to #89 , and as seen in #92(comment):

  • check for labels doc and test
  • check for a max number of files

Question: what is the ideal number of files? I would go for three, but I'm not an expert...

@Tiriel Tiriel added the feature request New features for node-core-utils label Nov 7, 2017
@alopezsanchez
Copy link
Contributor

Hello!

It's not possible to retrieve files/diffs at the moment with GraphQL API (https://github.com/joyeecheung/node-core-utils/issues/68#issuecomment-342031633), so I'm afraid we have to wait for the second point.

But I can do the first one if there are no incoveniences.

@apapirovski
Copy link
Member

I would probably suggest holding off. I feel like this is something that needs to be discussed within Node.js itself a bit...

IMO a lot of this could be simplified by setting a 24 hour limit (instead of 48 hours) on doc, test & code-and-learn changes. Then it can stop being so arbitrary.

/cc @addaleax, @joyeecheung

@alopezsanchez
Copy link
Contributor

Oh, okay @apapirovski, I didn't know that. Thank you!

@vsemozhetbyt
Copy link
Contributor

New rules landed: nodejs/node#17056
In PRs like this the warning may need to be suppressed.

@joyeecheung
Copy link
Member

Fixed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features for node-core-utils
Projects
None yet
Development

No branches or pull requests

5 participants