Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eu-strip from node tarball #245

Closed
jvelezpo opened this issue May 4, 2018 · 3 comments
Closed

remove eu-strip from node tarball #245

jvelezpo opened this issue May 4, 2018 · 3 comments

Comments

@jvelezpo
Copy link

jvelezpo commented May 4, 2018

nodejs 10.0.0 tarball contains deps/v8/third_party/eu-strip/
and it was removed on this PR nodejs/node#20304

now we need to stop it coming back the next time V8 is updated. I have been trying to do this but i havent been able to do it, if anyone can help me figure it out how to do it, or if anyone wants to send a PR it will be awesome as well.

@priyank-p
Copy link
Contributor

@jvelezpo this is already implemented in #243, so if you use git node v8 to update this should be taken care of next time.

@priyank-p
Copy link
Contributor

Closing issue, since it's something already done.

@jvelezpo
Copy link
Author

jvelezpo commented May 4, 2018

@priyankp10 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants