Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Hook up support for VM.Script.createCachedData #560

Open
mike-kaufman opened this issue Jun 28, 2018 · 0 comments
Open

Hook up support for VM.Script.createCachedData #560

mike-kaufman opened this issue Jun 28, 2018 · 0 comments

Comments

@mike-kaufman
Copy link
Contributor

This commit added support for a new API vm.script.createCachedData.

This calls chakrashim's CreateCachedData, which is not currently hooked up.

A few things need to happen here:

  1. We need to wire up CreateCachedData to call Jsrt's JsSerialize - this will serialize the given script into an array buffer.
  2. We need to enure that Node's node_contextify.cc CreateCachedData is doing the "right thing" with this as a return value.
  3. We need to ensure that chakrashim's ScriptCompiler::Source is doing the right thing with the cached_data param if passed in. That is, if specified, we expect cached_data to be a buffer produced as from a call to JsSerialize, and we should use it appropriately. Currently, Source just drops this.
  4. We need to re-enable the test test/parallel/test-vm-createcacheddata.js, which is currently disabled for node-chakracore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant