Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit bbcf831

Browse files
committed
lib: removing contents of v8 module under chakracore
The v8 module uses functionality which is not supported by chakracore. Rather than expose stubs which have unexpected behavior, we now do not expose anything in the v8 module, so dependant modules can do feature detection. PR-URL: #491 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
1 parent 17b469b commit bbcf831

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

Diff for: lib/v8.js

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414

1515
'use strict';
1616

17+
if (process.jsEngine === 'chakracore') {
18+
return;
19+
}
20+
1721
const { Buffer } = require('buffer');
1822
const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
1923
const {

Diff for: test/parallel/parallel.status

+5
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,11 @@ test-fs-readdir-stack-overflow : SKIP
173173
# in a particular way which is true for v8 but not true for charkacore
174174
test-string-decoder-end : SKIP
175175

176+
# These tests use the v8 module which chakracore does not support
177+
test-process-exception-capture-should-abort-on-uncaught-setflagsfromstring : SKIP
178+
test-v8-flag-type-check : SKIP
179+
test-v8-stats : SKIP
180+
176181
[$jsEngine==chakracore && $arch==x64]
177182
# These tests are failing for Node-Chakracore and should eventually be fixed
178183
test-buffer-includes : SKIP

0 commit comments

Comments
 (0)