Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 8fb8d14

Browse files
digitalinfinitychakrabot
authored andcommitted
deps: update ChakraCore to chakra-core/ChakraCore@8c0764e1aa
[1.8>1.9] [MERGE #4631 @digitalinfinity] OS 15681335: Fix inspection of Promise state in debugger Merge pull request #4631 from digitalinfinity:os_15681335_1.8 RecyclablePromiseObjectWalker::Get had a missing break when inspecting the state of a promise, causing an unresolved promise to show up as resolved in F12. Fixed the logic here. Reviewed-By: chakrabot <[email protected]>
1 parent fb1f064 commit 8fb8d14

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Diff for: deps/chakrashim/core/lib/Runtime/Debug/DiagObjectModel.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -3896,6 +3896,7 @@ namespace Js
38963896
break;
38973897
case JavascriptPromise::PromiseStatusCode_Unresolved:
38983898
pResolvedObject->obj = scriptContext->GetLibrary()->CreateStringFromCppLiteral(_u("pending"));
3899+
break;
38993900
case JavascriptPromise::PromiseStatusCode_HasResolution:
39003901
pResolvedObject->obj = scriptContext->GetLibrary()->CreateStringFromCppLiteral(_u("resolved"));
39013902
break;

Diff for: deps/chakrashim/core/test/DebuggerCommon/promiseDisplay.js.dbg.baseline

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"someOtherProp": "string before",
1313
"[Promise]": {
14-
"[status]": "string resolved",
14+
"[status]": "string pending",
1515
"[value]": "string undefined"
1616
}
1717
}

0 commit comments

Comments
 (0)