Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Commit 887e882

Browse files
chakrashim: Fix Error.captureStackTrace
Error.captureStackTrace did not convert the type of line and column numbers to numbers while creating the v8 capture objects. This breaks modules which assumes number types. Changed to call parseInt if line and column numbers are defined PR-URL: #483 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
1 parent 76baebd commit 887e882

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: deps/chakrashim/lib/chakra_shim.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,8 @@
157157
const fileDetails = stackDetails[2].split(fileDetailsSplitter);
158158

159159
const fileName = fileDetails[0];
160-
const lineNumber = fileDetails[1] ? fileDetails[1] : 0;
161-
const columnNumber = fileDetails[3] ? fileDetails[3] : 0;
160+
const lineNumber = fileDetails[1] ? parseInt(fileDetails[1]) : 0;
161+
const columnNumber = fileDetails[3] ? parseInt(fileDetails[3]) : 0;
162162

163163
errstack.push(new StackFrame(func, funcName, fileName, lineNumber,
164164
columnNumber));

0 commit comments

Comments
 (0)